🤖 fix: prevent ForceDeleteModal overflow with long error logs #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added max-height constraints to prevent massive error logs from pushing the Force Delete button off-screen: - ErrorCodeBlock: max-h-[400px] with overflow-auto for scrollable logs - Modal: maxHeight support with overflow-y-auto when constrained - ForceDeleteModal: maxHeight="90vh" to ensure modal fits viewport
ammario
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ErrorCodeBlock now has a 400px max-height with scrolling, and the modal itself is constrained to 90vh to ensure the Force Delete button always remains visible.
Generated with
cmux